VideoBackends: add support to allow rendering to multiple output targets #11859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwubcode
force-pushed
the
backend-multi-output
branch
5 times, most recently
from
56fb8cc to
72af1dd
Compare
This comment was marked as resolved.
This comment was marked as resolved.
iwubcode
force-pushed
the
backend-multi-output
branch
2 times, most recently
from
af918f4 to
a1715f1
Compare
iwubcode
force-pushed
the
backend-multi-output
branch
from
a1715f1 to
8c3dc5b
Compare
TellowKrinkle
approved these changes
Jun 5, 2023
| @@ -19,7 +19,7 @@ namespace VideoCommon | |||
| // As pipelines encompass both shader UIDs and render states, changes to either of these should | |||
| // also increment the pipeline UID version. Incrementing the UID version will cause all UID | |||
| // caches to be invalidated. | |||
| constexpr u32 GX_PIPELINE_UID_VERSION = 6; // Last changed in PR 10890 | |||
| constexpr u32 GX_PIPELINE_UID_VERSION = 7; // Last changed in PR 11859 | |||
There was a problem hiding this comment.
Technically, adding a new field to an existing bitfield where zero is the same as the current usage shouldn't break any UIDs
|
So are we bumping the UID or not? |
|
FYI I asked Tellow what they meant by their comment and this was their response:
I wouldn't say I'm worried but I didn't think it hurt anything, so figured why not be safe? Happy to go either way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was used in #10362 and will be used in future features. Splitting it out to cut down on scope and make it easier to review