Implement preliminary Triforce support Pt.2 #10207
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zopolis4
force-pushed
the
exibackuptest
branch
from
c768723 to
fced217
Compare
Zopolis4
force-pushed
the
exibackuptest
branch
2 times, most recently
from
aaa29ee to
6d6e4bf
Compare
Zopolis4
force-pushed
the
exibackuptest
branch
from
391d198 to
79aefac
Compare
|
Marking this as ready for review because it's.... ready for review. Not for merge though, it still depends on #10084 and i'll rebase this after it gets merged. No compatibility improvements here unfortunately, it still depends on some SI stuff. I'll be taking a break for a while, and it'll be quite a while before any SI commits show up, so hopefully I won't have to make a part 3. |
Zopolis4
force-pushed
the
exibackuptest
branch
from
1540b0f to
03f9fb6
Compare
Zopolis4
force-pushed
the
exibackuptest
branch
3 times, most recently
from
8f3ae16 to
c4e2751
Compare
|
Note: this is still very much a WIP, seeing as the triforce name code still doesn't work for some reason, and I need to implement a few other EXI commands. |
Zopolis4
force-pushed
the
exibackuptest
branch
from
c4e2751 to
b2820de
Compare
Zopolis4
force-pushed
the
exibackuptest
branch
2 times, most recently
from
a330ceb to
8754002
Compare
Rumi-Larry
reviewed
May 2, 2022
Zopolis4
force-pushed
the
exibackuptest
branch
2 times, most recently
from
8feef2d to
6aa935a
Compare
Zopolis4
force-pushed
the
exibackuptest
branch
6 times, most recently
from
5f78bc8 to
72597a9
Compare
Zopolis4
force-pushed
the
exibackuptest
branch
from
6414c88 to
03a2c12
Compare
Zopolis4
force-pushed
the
exibackuptest
branch
from
6d1a1aa to
61473d5
Compare
…oes also like seem to not work? anyways add another return value to the buffer because knowledge is power
Zopolis4
force-pushed
the
exibackuptest
branch
from
ffbd73f to
d7ff55d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm splitting these changes into a new PR because I don't want the old one to get too bloated. This PR will be working on the EXI baseboard connection, and should hopefully get some more games booting. Obviously, this depends on #10084, and when that is merged I'll fully clean up the commit history on this branch. Right now this is just here to get some feedback on the latest changes.