Skip to content

Commit

Permalink
Common/BitSet: Zero initialize data member
Browse files Browse the repository at this point in the history
Gets rid of the need to remember to initialize them in the constructor,
except when overriding the default initializer.
  • Loading branch information
lioncash committed Jan 25, 2023
1 parent 6446fa7 commit 0d93a31
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions Source/Core/Common/BitSet.h
Original file line number Diff line number Diff line change
Expand Up @@ -93,11 +93,10 @@ class BitSet
int m_bit;
};

constexpr BitSet() : m_val(0) {}
constexpr BitSet() = default;
constexpr explicit BitSet(IntTy val) : m_val(val) {}
constexpr BitSet(std::initializer_list<int> init)
{
m_val = 0;
for (int bit : init)
m_val |= (IntTy)1 << bit;
}
Expand Down Expand Up @@ -132,7 +131,7 @@ class BitSet
constexpr unsigned int Count() const { return std::popcount(m_val); }
constexpr Iterator begin() const { return ++Iterator(m_val, 0); }
constexpr Iterator end() const { return Iterator(m_val, -1); }
IntTy m_val;
IntTy m_val{};
};
} // namespace Common

Expand Down

0 comments on commit 0d93a31

Please sign in to comment.