StoreAdapter: Add test and proposed fix for totalLength promise

dojo · Mar 19, 2015 · 9cc63ae · 9cc63ae
1 parent a98fb32
commit 9cc63ae
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/legacy/StoreAdapter.js b/legacy/StoreAdapter.js
@@ -119,7 +119,7 @@ define([
 			if (results) {
 				// apply the object restoration
 				return new QueryResults(results.map(this._restore, this), {
-					totalLength: results.total
+					totalLength: when(results.total)
 				});
 			}
 			return results;

diff --git a/tests/legacy/StoreAdapter-Memory.js b/tests/legacy/StoreAdapter-Memory.js
@@ -55,6 +55,13 @@ define([
 			assert.strictEqual(results[1].describe(), 'four is not a prime');
 		},
 
+		fetch: function () {
+			var totalLength = store.fetch().totalLength;
+			assert.isDefined(totalLength, 'totalLength should be defined on fetch results');
+			assert.strictEqual(typeof totalLength.then, 'function',
+				'totalLength should be a promise');
+		},
+
 		'filter': function () {
 			assert.strictEqual(getResultsArray(store.filter({prime: true})).length, 3);
 			assert.strictEqual(getResultsArray(store.filter({even: true}))[1].name, 'four');