Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass features map down to BTR #466

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

KaneFreeman
Copy link
Member

@KaneFreeman KaneFreeman commented May 12, 2021

Type: bug

The following has been addressed in the PR:

  • There is a related issue
  • All code has been formatted with prettier
  • Unit or Functional tests are included in the PR
  • schema.json has been updated appopriately

Description:
Pass features map down to BTR

Dependent on dojo/webpack-contrib#329

Resolves dojo/webpack-contrib#306

@KaneFreeman KaneFreeman force-pushed the feature/improved-error-message-for-btr-link-failure branch from 92d6fae to 319c013 Compare May 12, 2021 17:29
@codecov
Copy link

codecov bot commented May 14, 2021

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 43.50%. Comparing base (7b72a3f) to head (ae55ea3).
Report is 12 commits behind head on master.

Files with missing lines Patch % Lines
src/base.config.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #466   +/-   ##
=======================================
  Coverage   43.50%   43.50%           
=======================================
  Files          12       12           
  Lines         878      878           
  Branches      265      265           
=======================================
  Hits          382      382           
  Misses        496      496           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KaneFreeman KaneFreeman requested review from matt-gadd and agubler May 19, 2021 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Has/feature flags are not available when running a block in build time rendering
1 participant