Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: better slow pan: if user intent is to stay on current page, _don't_ change page #731

Conversation

dohooo
Copy link
Owner

@dohooo dohooo commented Nov 29, 2024

Description

#596

Review

  • I self-reviewed this PR

Testing

  • I added/updated tests
  • I manually tested

Copy link

vercel bot commented Nov 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-reanimated-carousel ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 29, 2024 9:29am

Copy link

changeset-bot bot commented Nov 29, 2024

🦋 Changeset detected

Latest commit: acc2c96

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
react-native-reanimated-carousel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Owner Author

dohooo commented Nov 29, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@dohooo dohooo marked this pull request as ready for review November 29, 2024 09:28
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Nov 29, 2024
@dohooo dohooo merged commit 6e8cdb4 into main Nov 29, 2024
5 of 6 checks passed
@dohooo dohooo deleted the 11-29-fix_better_slow_pan_if_user_intent_is_to_stay_on_current_page__don_t__change_page branch November 29, 2024 09:30
Copy link

codecov bot commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 74.35%. Comparing base (86142e0) to head (acc2c96).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/components/ScrollViewGesture.tsx 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #731      +/-   ##
==========================================
- Coverage   74.63%   74.35%   -0.28%     
==========================================
  Files          35       35              
  Lines         816      819       +3     
  Branches      236      237       +1     
==========================================
  Hits          609      609              
- Misses        143      145       +2     
- Partials       64       65       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant