fix: dependency array; removes shared value access warning from react…

…-native-reanimated (#710) * fix: dependency array in ScrollViewGesture activeDecay should not include .value; orig was eb21293 * fix: dependency array in ScrollViewGesture resetBoundary should not include .value; orig was eb21293 * chore: npx changeset
dohooo · Nov 23, 2024 · d98bb99 · d98bb99
1 parent 2c2a8e2
commit d98bb99
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/.changeset/rare-insects-camp.md b/.changeset/rare-insects-camp.md
@@ -0,0 +1,5 @@
+---
+"react-native-reanimated-carousel": patch
+---
+
+fix: remove shared value access warning from react-native-reanimated
diff --git a/src/components/ScrollViewGesture.tsx b/src/components/ScrollViewGesture.tsx
@@ -205,7 +205,7 @@ const IScrollViewGesture: React.FC<PropsWithChildren<Props>> = (props) => {
       { velocity: scrollEndVelocity.value },
       isFinished => onFinish(isFinished as boolean),
     );
-  }, [onFinish, scrollEndVelocity.value, touching, translation]);
+  }, [onFinish, scrollEndVelocity, touching, translation]);
 
   const resetBoundary = React.useCallback(() => {
     "worklet";
@@ -232,11 +232,11 @@ const IScrollViewGesture: React.FC<PropsWithChildren<Props>> = (props) => {
         translation.value = withSpring(-((maxPage - 1) * size));
     }
   }, [
-    touching.value,
+    touching,
     translation,
     maxPage,
     size,
-    scrollEndTranslation.value,
+    scrollEndTranslation,
     loop,
     activeDecay,
     withSpring,