Skip to content

Add $stddevsamp compatibility tests#661

Open
Jhr-4 wants to merge 14 commits into
documentdb:mainfrom
Jhr-4:feature/stddevsamp-second-pass
Open

Add $stddevsamp compatibility tests#661
Jhr-4 wants to merge 14 commits into
documentdb:mainfrom
Jhr-4:feature/stddevsamp-second-pass

Conversation

@Jhr-4

@Jhr-4 Jhr-4 commented Jun 30, 2026

Copy link
Copy Markdown

Add compatibility test coverage for $stdDevSamp expression operator covering core, boundary, type validation, null/missing cases.

Jhr-4 added 12 commits June 19, 2026 16:13
Signed-off-by: Jay <jhr4@njit.edu>
Signed-off-by: Jay <jhr4@njit.edu>
Signed-off-by: Jay <jhr4@njit.edu>
Signed-off-by: Jay <jhr4@njit.edu>
Signed-off-by: Jay <jhr4@njit.edu>
Signed-off-by: Jay <jhr4@njit.edu>
Signed-off-by: Jay <jhr4@njit.edu>
Signed-off-by: Jay <jhr4@njit.edu>
Signed-off-by: Jay <jhr4@njit.edu>
Signed-off-by: Jay <jhr4@njit.edu>
@Jhr-4 Jhr-4 requested a review from a team as a code owner June 30, 2026 23:00
Copilot AI review requested due to automatic review settings June 30, 2026 23:00

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a comprehensive compatibility test suite for the $stdDevSamp expression accumulator under core/operator/expressions/accumulator/stdDevSamp/, covering core math behavior, boundary/precision behaviors, null/missing semantics, non-numeric handling, and special floating-point values.

Changes:

  • Introduces core correctness tests across numeric BSON types and representative numeric patterns (mixed types, negative values, large N, zero variance).
  • Adds targeted suites for boundary/precision-loss scenarios and for NaN/Infinity propagation behavior.
  • Adds input-form coverage (literal traversal, expression operands, field-path traversal, and invalid field-path parsing) plus null/missing and non-numeric ignore rules.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
documentdb_tests/compatibility/tests/core/operator/expressions/accumulator/stdDevSamp/test_expression_stdDevSamp_core.py Core numeric correctness and baseline rules (N<2 → null, zero variance, mixed types).
documentdb_tests/compatibility/tests/core/operator/expressions/accumulator/stdDevSamp/test_expression_stdDevSamp_boundaries.py Boundary and precision-loss/overflow behaviors for ints/doubles.
documentdb_tests/compatibility/tests/core/operator/expressions/accumulator/stdDevSamp/test_expression_stdDevSamp_special_values.py NaN/Infinity behavior coverage for float + Decimal128.
documentdb_tests/compatibility/tests/core/operator/expressions/accumulator/stdDevSamp/test_expression_stdDevSamp_null_missing.py Null/missing handling coverage (scalar + array shapes).
documentdb_tests/compatibility/tests/core/operator/expressions/accumulator/stdDevSamp/test_expression_stdDevSamp_non_numeric.py Behavior when inputs include non-numeric BSON types (ignored vs scalar).
documentdb_tests/compatibility/tests/core/operator/expressions/accumulator/stdDevSamp/test_expression_stdDevSamp_input_forms.py Expression input forms (literal traversal, operands, document paths) + invalid field path errors.

@documentdb-triage-tool

Copy link
Copy Markdown

🤖 Auto-triaged by documentdb-triage-tool.

Applied: compatibility test, enhancement
Project fields suggested: Component test-coverage · Priority P2 · Effort L · Status Needs Review
Confidence: 0.30 (deterministic)

Reasoning

component from path globs (test-coverage); effort from diff stats (859+0 LOC, 6 files); LLM failed: Invalid response body while trying to fetch https://api.anthropic.com/v1/messages: Premature close

If a label is wrong, remove it manually and ping @patty-chow so the rules can be tuned. The bot will not re-label items that already have component labels.

@documentdb-triage-tool documentdb-triage-tool Bot added compatibility test Compatibility test related enhancement New feature or request labels Jun 30, 2026
@Jhr-4 Jhr-4 changed the title Feature/stddevsamp second pass Add $stddevsamp compatibility tests Jun 30, 2026
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Signed-off-by: Jay <jhr4@njit.edu>
@Jhr-4 Jhr-4 force-pushed the feature/stddevsamp-second-pass branch from 7dcbd43 to 0883bcc Compare July 1, 2026 00:20
Signed-off-by: Jay <jhr4@njit.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

compatibility test Compatibility test related enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants