Create postGenerateComparisonSchema event #11374
Conversation
|
It seems there are CI jobs failing. Please take a look at this guide for more on how to handle those. |
wmouwen
force-pushed
the
event-listener-migration-schema
branch
from
30cdf61 to
c946ff3
Compare
|
Retargeting to 3.1.x since 3.0.x is not maintained anymore. |
|
Please kindly squash your commits together. If you don't, we'll try to remember to do it for you but it's best if you save us this trouble. How to do that?
|
wmouwen
force-pushed
the
event-listener-migration-schema
branch
from
7fc5f68 to
71d6576
Compare
|
Since this is not a patch, I think we should target 3.2.x 🤔 |
derrabus
dismissed stale reviews from SenseException and greg0ire
The base branch was changed.
Yes. 3.2.x is a bit behind. I'll retarget after a merge up. |
| ); | ||
| $schemaTool = new SchemaTool($em); | ||
|
|
||
| $schema = $schemaTool->getUpdateSchemaSql([]); |
| self::assertTrue($listener->schemaCalled); | ||
| self::assertTrue($listener->comparisonSchemaCalled); |
There was a problem hiding this comment.
The test does not really show me that I was able to influence the generated schema or SQL.
There was a problem hiding this comment.
Tried to improve the tests. This should show you that you can access the schema which the comparator uses.
wmouwen
force-pushed
the
event-listener-migration-schema
branch
from
71d6576 to
5ba0c02
Compare
wmouwen
force-pushed
the
event-listener-migration-schema
branch
from
5086074 to
1b938ab
Compare
|
There hasn't been any activity on this pull request in the past 90 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days. |
|
This pull request was closed due to inactivity. |
Schemas generated from metadata cause the event
ToolEvents::postGenerateSchemato be triggered in the methodSchemaTool::getSchemaFromMetadata. It would be helpful to do the same for schemas generated for comparison inSchemaTool::createSchemaForComparison. This PR introduces the new eventToolEvents::postGenerateComparisonSchema.PR relates to an attempt to fix doctrine/migrations#1406. It is a requirement of doctrine/migrations#1418 and doctrine/DoctrineMigrationsBundle#529.