PHPORM-439 Initialize the make:document command
#3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulinevos
reviewed
Jan 14, 2026
| $runner->runMaker([ | ||
| // document class name | ||
| 'User', | ||
| // add not additional fields |
There was a problem hiding this comment.
add no additional fields I'm guessing?
| ); | ||
|
|
||
| if ($withDatabase) { | ||
| $runner->updateSchema(); |
There was a problem hiding this comment.
What does updateSchema actually do in a MongoDB context?
| return in_array(lcfirst($name), self::MONGODB_KEYWORDS, true); | ||
| } | ||
|
|
||
| public function getDocumentNamespace(): string |
There was a problem hiding this comment.
Might be nice to unit test this helper separately
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests require change to Symfony MakerBundle:
MakerTestCasesymfony/maker-bundle#1770doctrine/mongodb-odm-bundlean official recipe symfony/recipes#1509