Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/restapi.plugin.coffee
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,13 @@ module.exports = (BasePlugin) ->
message: err.message+': \n'+err.stack.toString()
)

# Send Unauthorized
sendUnauthorized = (res) ->
res.status(403).send(
success: false
message: "Unauthorized"
)

# Prepare file data for sending
prepareFile = (file, additionalFields) ->
# Prepare
Expand Down Expand Up @@ -459,8 +466,12 @@ module.exports = (BasePlugin) ->
# Prepare
method = req.method.toLowerCase()

# Check readonly
if plugin.config.readonly and method isnt 'get'
sendUnauthorized(res)

# GET / READ
if method is 'get'
else if method is 'get'
# Fetch
collectionName = req.params.collectionName
relativePath = req.params[0]
Expand Down
50 changes: 50 additions & 0 deletions src/restapi.tester.coffee
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,28 @@ module.exports = (testers) ->
return next(err)
return next()

# Send and verify unauthorized response
requestWithUnauthorizedCheck = (method, next) ->
request method, 'collection/documents/posts/test.txt', {}, (err, res) ->
# Check
return next(err) if err

# Compare
actual = res.body
expected =
success: false
message: "Unauthorized"

# Check
try
expect(res.status, 'response status was not expected').to.equal(403)
expect(actual, 'response result should be as expected').to.deep.equal(expected)
catch err
console.log JSON.stringify(actual, null, ' ')
console.log JSON.stringify(expected, null, ' ')
return next(err)
return next()

# Collections
suite 'collections', (suite,test) ->
test 'check listing', (done) ->
Expand Down Expand Up @@ -215,6 +237,34 @@ module.exports = (testers) ->
requestData = {}
requestWithCheck('get', 'collection/documents/', requestData, responseData, done)

# Configuration
suite 'configuration', (suite, test) ->
# Set readonly config option
setup = (test, complete) ->
pluginConfig.readonly = true
complete()

# Enable default REST behaviour
tearDown = (test, complete) ->
pluginConfig.readonly = false
complete()

# Unauthorised POST test
test 'check POST fails', { before: setup, after: tearDown }, (done) ->
requestWithUnauthorizedCheck('post', done)

# Unauthorised DELETE test
test 'check DELETE fails', { before: setup, after: tearDown }, (done) ->
requestWithUnauthorizedCheck('delete', done)

# Unauthorised PUT test
test 'check PUT fails', { before: setup, after: tearDown }, (done) ->
requestWithUnauthorizedCheck('put', done)

test 'check GET is successful', { before: setup, after: tearDown }, (done) ->
responseData = files
requestData = {}
requestWithCheck('get', 'collection/documents/', requestData, responseData, done)

# Test Custom
testCustom: => @clean()