Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image load: don't depend on deprecated JSONMessage.error field #3307

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

thaJeztah
Copy link
Member

The error field was deprecated in favor of the errorDetail struct in moby@3043c26, but the API continued to return both. This patch updates docker-py to not depend on the deprecated field.

The error field  was deprecated in favor of the errorDetail struct in
[moby@3043c26], but the API continued to return both. This patch updates
docker-py to not depend on the deprecated field.

[moby@3043c26]: moby/moby@3043c26

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah self-assigned this Jan 14, 2025
Copy link
Member

@p1-0tr p1-0tr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (not an expert on either the moby API or python, so "seems to do what it says on the tin" could be more accurate)

@thompson-shaun thompson-shaun merged commit 747d23b into docker:main Jan 17, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants