Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP 8.4 support #932

Merged
merged 1 commit into from
Mar 13, 2025
Merged

Conversation

thueske
Copy link
Contributor

@thueske thueske commented Nov 23, 2024

@thueske
Copy link
Contributor Author

thueske commented Nov 23, 2024

Would be super cool if we already have a PHP 8.4 image with WordPress to test the compatibility of plugins & themes.

Maybe @LaurentGoderre or @tianon can take a look at the PR?

@tianon
Copy link
Member

tianon commented Nov 25, 2024

This is a great idea! Unfortunately, it looks like we get hung up on Imagick/imagick#689 (and thus need Imagick/imagick#690). 😞

@sebcode
Copy link

sebcode commented Nov 27, 2024

pecl imagick is basically unmaintained.

@thueske This adds necessary patches to this PR to make the build work with php 8.4: thueske#1

@tianon
Copy link
Member

tianon commented Nov 27, 2024

Has there been any work in WordPress upstream to evaluate this dependency (and alternatives)?

@sebcode
Copy link

sebcode commented Nov 28, 2024

@tianon I’m not aware of any alternatives being actively considered. Imagemagick is the best option for processing images with PHP. GD is a works too but produces lower-quality images. Main issue is the lack of proper maintainer support of the pecl wrapper library. I think for now, the best approach is patching the library, which is also what Ondřej (maintainer of the widely-used PHP packages for Debian and Ubuntu) does.

@thueske
Copy link
Contributor Author

thueske commented Dec 7, 2024

Any updates based on this #932 (comment)? Would be great to have PHP 8.4 :)

@thueske
Copy link
Contributor Author

thueske commented Dec 11, 2024

WordPress 6.7 adds PHP 8.4 beta support. The latest commit from imagick is Mar 18, 2023. I think the patch here from @sebcode is the best solution.

@swissspidy
Copy link
Contributor

Some update on the ImageMagick side:

Imagick/imagick#690 (comment)

@tianon tianon force-pushed the feature/add-php-84 branch from 29ce2cf to 89a9728 Compare March 13, 2025 21:37
@tianon
Copy link
Member

tianon commented Mar 13, 2025

I've just force pushed this with a rebase+squash and an update to use the freshly-released https://pecl.php.net/package/imagick/3.8.0RC2 for PHP 8.4 (leaving other versions as-is on 3.7.0+patch given it's a pre-release).

@tianon tianon requested a review from yosifkit March 13, 2025 21:55
@yosifkit yosifkit merged commit bfb6380 into docker-library:master Mar 13, 2025
30 checks passed
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Mar 13, 2025
Changes:

- docker-library/wordpress@bfb6380: Merge pull request docker-library/wordpress#932 from thueske/feature/add-php-84
- docker-library/wordpress@89a9728: Add PHP 8.4 support
@thueske
Copy link
Contributor Author

thueske commented Mar 14, 2025

Thank you! There aren't any multi-arch builds yet, is this a normal behavior?

@yosifkit
Copy link
Member

Thank you! There aren't any multi-arch builds yet, is this a normal behavior?

Yeah, different architectures build at different speeds, and they are added to the image index as they are finished. We also merged a php security update at the same time, so the queues were (and are) still full for some architectures (https://doi-janky.infosiftr.net/). It looks like quite a few have finished building the wordpress:*php8.4* images and they are available on Docker Hub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants