Size tests #2240
Size tests #2240
Conversation
Updating fork...
Add routine to check space on CHROOTS partiton and ChrUbuntu partitions
check_space checks that the minimum partition size and free space is met. check_ubuntu checks if partition 7 is being used and reports it's sizes and configuration
Added return values for check_chrubuntu in case we decide to use them.
'df' command in check_chrubuntu changed to use mountpoint instead of partition.
Moved check_space variable declarations to top of file with the others.
installer/functions
Outdated
There was a problem hiding this comment.
quotes added.
|
Thanks for the patch!! Catching up on reviewing things now :) |
Updated to incorporate changes per line notes from @dnschneid
Updated to incorporate changes per line notes from @dnschneid
Thank you for all the help and time out of your busy schedule. :) |
installer/functions
Outdated
Updated to incorporate changes per line notes from @dnschneid on 12/30/15.
installer/functions
Outdated
There was a problem hiding this comment.
whoa, too much indentation :)
read and if are at the same level.
There was a problem hiding this comment.
fixed indentation.
Updated to incorporate changes per line notes from @dnschneid on 1/1/16. Removed multiple delays and added message that installation will continue after 5s.
Updated to incorporate changes per line notes from @dnschneid on 1/1/16. Added missing quotes, fixed indentation, insured lines <=80 chars, sent warnings to stderr. Also reworked logic to check for existing mounts do to 'ro' mount failing if already mounted.
|
I apologize for all the misstarts ( I'm trying, very trying ;). |
|
You're doing great! |
Simplified logic for invoking check_dualboot function.
un-split warning messages. removed `proc/mounts` lookup and redid mount logic for mounted and unmounted partition. 'grep' and 'cut' replaced with 'awk'.
Well I certanly don't think so, it's down right embarrassking! |
|
I was thinking of changing some of my calculations to use decimals. The current ones are similar to:
When size is 19588, it yields '19GB' I'd like to change them to:
When size is 19588, it yields '19.58 GB' I wanted to check with y'all and see if that's something worthwhile doing ??? |
|
I would just round to 20GB It's not like you can buy a 19.58GB storage device ?? ;) |
|
Okay, thanx. I'll leave them as is then probably. |
|
If you want it to round up you can do something like: I'm not sure which is preferable... |
|
You could also consider using "df -mh" which will give you the size in 'human' readable format, such as 20GB. |
|
Yup, thought about that but it's just a little harder to test sizes when in a 'human' readable format. |
|
I think this is ready to go but you might want to review it again, it's been a while. |
|
@DennisLfromGA Let me know if you want me to test. During some wild attempts to get my Chromebook (Toshiba 2 2015) to run android apps, I lost Crouton, so have to reinstall, probably this weekend. |
|
@tedm, Go for it and let us know, thanx. |
dnschneid
force-pushed
the
master
branch
2 times, most recently
from
455c029 to
cebf84f
Compare
4 participants
Per Issue #2108 - Add destination size tests:
If the CHROOTS partition size is less than 4 GB, spit out a warning. If CHROOTS free space is less than 2GB, spit out a warning. Also, determine whether the former is due to a Chrubuntu install.