Skip to content

Commit

Permalink
python 2 and 3, after merge with current master (#437)
Browse files Browse the repository at this point in the history
* Breaking up Makefile into three pieces: linux, osx, and windows
* Ported code to work for both python 2 and 3
* assertItemsEqual was removed in python3. Also, we need to apply list to dict.keys() operations.
* Set the locale to en_US.UTF-8, this resolves the encoding problems
* pexepct.spawn needs to take an encoding argument in python 3
* Removed the shlex package, it is now distributed as part of the standard library. 
* sys.maxint has been removed in python 3
* Upgrading the argcomplete package and downloading it with pip. Removed out of date local copy of the code.
* Updating the script that builds the dxpy pypi package
* Removing unused (and hacky) python coverage report
  • Loading branch information
orodeh authored Nov 9, 2018
1 parent 4757a39 commit 6c6c5a1
Show file tree
Hide file tree
Showing 64 changed files with 1,299 additions and 3,187 deletions.
15 changes: 11 additions & 4 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
/build/info/version
/build/wrapper_table.json
/build/doc_env/
/build/py_env/
/build/py_env*/
/doc/cpp/
/doc/java/
/doc/ruby/
Expand Down Expand Up @@ -39,6 +39,7 @@ dxR.Rcheck
*.o
.DS_Store
/bin/dx
/bin/dx-run-app-locally
/bin/dx-app-wizard
/bin/dx-build-app
/bin/dx-build-applet
Expand All @@ -60,10 +61,7 @@ dxR.Rcheck
/bin/dx-variants-to-vcf
/bin/dx-verify-file
/bin/dx-print-bash-vars
/bin/activate-global-python-argcomplete
/bin/coverage*
/bin/python-argcomplete-check-easy-install-script
/bin/register-python-argcomplete
/bin/jq
/bin/py.test
/bin/pytest
Expand All @@ -76,6 +74,7 @@ dxR.Rcheck
/bin/easy_install*
/bin/chardetect
/bin/proot
/bin/pbr
/bin/wsdump.py
/bin/dx-su-contrib
/src/python/test/*.traceability.*.csv
Expand All @@ -85,3 +84,11 @@ dxR.Rcheck
/src/ua/ua
test-job-workspaces
.idea/

# Scripts that are installed as part of the argcomplete package
/bin/activate-global-python-argcomplete
/bin/python-argcomplete-check-easy-install-script
/bin/register-python-argcomplete

# artifacts from tracibility
*.traceability.*.csv
42 changes: 21 additions & 21 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ Categories for each release: Added, Changed, Deprecated, Removed, Fixed, Securit

## [267.0] - 2018.10.18 stable

### Added
### Added

* Add release/distro to example app `dxapp.json` files

Expand All @@ -40,7 +40,7 @@ Categories for each release: Added, Changed, Deprecated, Removed, Fixed, Securit
* `cat` argument too long in a bash script
* Ensure we can pop items from the main dictionary (python3)

### Changed
### Changed

* Warn user before `dx rm -r` on root of a project
* Let `urllib3` set default CA bundle on Windows
Expand Down Expand Up @@ -73,7 +73,7 @@ Categories for each release: Added, Changed, Deprecated, Removed, Fixed, Securit

* Sort inputs in `dx generate_batch_inputs`

## [262.0] - 2018.08.30
## [262.0] - 2018.08.30

### Removed

Expand All @@ -89,7 +89,7 @@ Categories for each release: Added, Changed, Deprecated, Removed, Fixed, Securit

* Windows installation

## [261.0]
## [261.0]

### Added

Expand All @@ -102,7 +102,7 @@ Categories for each release: Added, Changed, Deprecated, Removed, Fixed, Securit

* dxWDL version 0.74

## [259.0] - 2018.08.09
## [259.0] - 2018.08.09

### Added

Expand All @@ -114,7 +114,7 @@ Categories for each release: Added, Changed, Deprecated, Removed, Fixed, Securit
* `dx wait` where a file with object IDs is provided in path
* `dx compile` for debian install dxWDL.jar filepath

## [258.1] - 2018.08.06
## [258.1] - 2018.08.06

### Added

Expand Down Expand Up @@ -191,7 +191,7 @@ Categories for each release: Added, Changed, Deprecated, Removed, Fixed, Securit

### Added

* "Deleted" field to `dx describe globalworkflow-xxxx`
* "Deleted" field to `dx describe globalworkflow-xxxx`
* a note to `dx describe` that the workflow is locked

## [252.0] - 2018.04.26
Expand Down Expand Up @@ -226,11 +226,11 @@ Categories for each release: Added, Changed, Deprecated, Removed, Fixed, Securit

## [250.0]

### Added
### Added

* Support for `dx describe` for global workflows

## [249.0] -2018.04.05
## [249.0] -2018.04.05

### Added

Expand Down Expand Up @@ -308,7 +308,7 @@ Categories for each release: Added, Changed, Deprecated, Removed, Fixed, Securit

* Recursive search for asset in a path is disabled, and we strictly enforce only one matching asset name

## [242.0] - 2018.01.25
## [242.0] - 2018.01.25

### Changed

Expand Down Expand Up @@ -376,7 +376,7 @@ Categories for each release: Added, Changed, Deprecated, Removed, Fixed, Securit
### Added

* dx-clone-asset script
* `dx-docker`: ignore user argument if given
* `dx-docker`: ignore user argument if given
* TLS documentation

### Changed
Expand All @@ -403,7 +403,7 @@ Categories for each release: Added, Changed, Deprecated, Removed, Fixed, Securit

### Added

* Azure instance types to the list of available types in `dx-app-wizard`
* Azure instance types to the list of available types in `dx-app-wizard`
* ua -- test now displays system messages coming from the apiserver.

### Changed
Expand All @@ -427,15 +427,15 @@ Categories for each release: Added, Changed, Deprecated, Removed, Fixed, Securit

* Execution of old workflows built without explicit IO

## [231.0] - 2017.08.24
## [231.0] - 2017.08.24

### Added

* CLI support for workflow lockdown

### Removed

* Deprecated `dx-mount`
* Deprecated `dx-mount`

## [230.0] - 2017.08.17

Expand Down Expand Up @@ -542,7 +542,7 @@ Categories for each release: Added, Changed, Deprecated, Removed, Fixed, Securit

### Changed

* `dx ls -l` and friends now request only needed describe fields
* `dx ls -l` and friends now request only needed describe fields

## [219.0] - 2017-04-28

Expand All @@ -564,9 +564,9 @@ Categories for each release: Added, Changed, Deprecated, Removed, Fixed, Securit

* `dx get workflow-xxxx` creates a local representation of a workflow

## [217.0] - 2017-04-13
## [217.0] - 2017-04-13

No significant changes.
No significant changes.

## [216.1] - 2017-04-06

Expand All @@ -590,7 +590,7 @@ No significant changes.

### Fixed

* missing pyasn1 module for OSX list of install dependencies; gets rid of import warning messages
* missing pyasn1 module for OSX list of install dependencies; gets rid of import warning messages

## [214.0]

Expand Down Expand Up @@ -638,14 +638,14 @@ No significant changes.

No significant changes.

## [210.0] - 2017-02-16
## [210.0] - 2017-02-16

### Fixed

* Fix `dx get` untar issue with leading /
* Missing `dx-verify-file` and `jq` dependencies on Windows

## [209.0] - 2017-02-09
## [209.0] - 2017-02-09

### Added

Expand All @@ -654,7 +654,7 @@ No significant changes.

### Fixed

* Environment file so that `source environment` works properly on RHEL7
* Environment file so that `source environment` works properly on RHEL7
* Modified `dx-docker` so that `--rm` passes through gracefully
* Modified `dx-docker` so that the `HOME` environment variable defaults to `/root`

Expand Down
6 changes: 0 additions & 6 deletions bin/dxfs

This file was deleted.

55 changes: 0 additions & 55 deletions bin/python-argcomplete-check-easy-install-script

This file was deleted.

23 changes: 23 additions & 0 deletions bin/python-argcomplete-tcsh
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
#!/bin/sh
IFS=
export IFS

COMP_WORDBREAKS=
export COMP_WORDBREAKS

COMP_TYPE=
export COMP_TYPE

COMP_LINE=${COMMAND_LINE}
export COMP_LINE

COMP_POINT=${#COMMAND_LINE}
export COMP_POINT

_ARGCOMPLETE=1
export _ARGCOMPLETE

_ARGCOMPLETE_SHELL=tcsh
export _ARGCOMPLETE_SHELL

"$1" 8>&1 9>&2 1>/dev/null 2>/dev/null
44 changes: 0 additions & 44 deletions bin/register-python-argcomplete

This file was deleted.

Loading

0 comments on commit 6c6c5a1

Please sign in to comment.