Skip to content

Commit

Permalink
resolve comments
Browse files Browse the repository at this point in the history
  • Loading branch information
Dmitry Shibanov committed Jun 22, 2020
1 parent ab28e0d commit 690909d
Show file tree
Hide file tree
Showing 7 changed files with 77 additions and 969 deletions.
12 changes: 6 additions & 6 deletions .github/workflows/versions.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,24 +24,24 @@ jobs:
with:
go-version: ^1.13.6

- name: validate version
run: go version | grep "go1."
- name: verify go
run: _tests__/verify-go.sh go1.13.6

- name: setup-go 1.13
uses: ./
with:
go-version: 1.13

- name: validate version
run: go version | grep "go1.13."
- name: verify go
run: _tests__/verify-go.sh go1.13.*

- name: setup-go 1.12.9
uses: ./
with:
go-version: 1.12.9

- name: validate version
run: go version | grep "go1.12.9"
- name: verify go
run: _tests__/verify-go.sh go1.12.9

- name: dump env
shell: bash
Expand Down
19 changes: 1 addition & 18 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,6 @@

This action sets up a go environment for use in actions by:

- optionally installing and adding to PATH a version of Go that is already installed in the tools cache
- downloading, installing and adding to PATH an available version of Go from GitHub Releases ([actions/go-versions](https://github.com/actions/go-versions/releases)) if a specific version is not available in the tools cache
- optionally downloading and caching a version of Go by version and adding to PATH
- registering problem matchers for error output

Expand Down Expand Up @@ -73,21 +71,6 @@ jobs:
go-version: ${{ matrix.go }}
- run: go run hello.go
```
Download and set up a version of Go that does not come preinstalled on an image:
```yaml
jobs:
build:
runs-on: ubuntu-latest
strategy:
go-version: [1.11.13, 1.12.17, 1.13.12, 1.14.4]
steps:
- uses: actions/checkout@v2
- uses: actions/setup-go@v1
with:
go-version: ${{ matrix.go }}
- run: go run my_go.go

```
# License
Expand All @@ -99,4 +82,4 @@ Contributions are welcome! See [Contributor's Guide](docs/contributors.md)
## Code of Conduct
:wave: Be nice. See [our code of conduct](CONDUCT)
:wave: Be nice. See [our code of conduct](CONDUCT)
Loading

0 comments on commit 690909d

Please sign in to comment.