feat: snowflake clustering key modifications
#3365
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
docs | 7a4fa56 | Commit Preview URL Branch Preview URL |
Nov 22 2025, 07:11 AM |
Collaborator
Author
|
Hey @rudolfix, could you review this PR? |
rudolfix
requested changes
Nov 23, 2025
Collaborator
rudolfix
left a comment
rudolfix
left a comment
There was a problem hiding this comment.
this is excellent! end to end test is missing though: where we actually run the queries on snowflake. you can add a pipeline testing this in test_snowflake_pipeline.py.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, the
snowflakedestination only interpretsclusterhints on table creation. Any subsequent changes inclusterhints are ignored. This PR changes that, such thatclusterhints are also interpreted on table alterations.These three cases are supported:
(1) add clustering: without clustering -> with clustering
(2) change clustering: change set of cluster columns or column order
(3) drop clustering: with clustering -> without clustering
Note that there is no active hint change detection. Any changes in
clusterhints are only processed when the current table alteration mechanism is triggered, which is only when a new column is added.Related Issues