Fix: type annotation failure in compute_columns_schema #3363
+89
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuunchin
force-pushed
the
fix/3345-missing-columns
branch
from
b63f151 to
58cae6d
Compare
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
docs | 079bb59 | Commit Preview URL Branch Preview URL |
Nov 21 2025, 06:22 PM |
anuunchin
force-pushed
the
fix/3345-missing-columns
branch
2 times, most recently
from
57d3bdd to
b0aafc2
Compare
anuunchin
force-pushed
the
fix/3345-missing-columns
branch
from
b0aafc2 to
06657aa
Compare
anuunchin
force-pushed
the
fix/3345-missing-columns
branch
from
06657aa to
591e5be
Compare
anuunchin
force-pushed
the
fix/3345-missing-columns
branch
from
591e5be to
079bb59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to resolve the issue where sqlglot is not able to annotate the type of a column.
Root cause: In some cases, the
selectsof theexpressionpassed to thecompute_columns_schemaindlt.dataset.lineage.pyinclude bare Identifiers.qualify()fails to qualify these bare Identifier nodes. Thenannotate_types()fails downstream because it's working with unqualified columns.Resolves #3345