Fix: primary_key not removed with apply_hints(primary_key="") #3280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
docs | ab6fe3b | Commit Preview URL Branch Preview URL |
Nov 21 2025, 10:12 AM |
anuunchin
force-pushed
the
fix/3210-primary-key-removal
branch
5 times, most recently
from
ef296ae to
830e921
Compare
anuunchin
force-pushed
the
fix/3210-primary-key-removal
branch
2 times, most recently
from
ae588c7 to
85b36e4
Compare
anuunchin
force-pushed
the
fix/3210-primary-key-removal
branch
from
85b36e4 to
ab6fe3b
Compare
Contributor
Author
|
Better solution in #3361 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to solve the issue where setting primary_key to an empty string or None in
apply_hintsdoes not actually remove it from schema.Resolves #3210