Initial merge as a beta plugin #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes all of the changes from the Pull Request into Fieldmanager (see alleyinteractive/wordpress-fieldmanager#399) except for the unit tests, which will take some more work to decouple.
|
🐝 as we had discussed. Probably worth having a JS dev look it over though. |
|
I talked a little more with @jameswburke about this PR, and we agreed that, for the purposes of the beta plugin, the current JavaScript is sufficient for merging so it can receive more testing. Whatever JS ends up in the the official Fieldmanager pull request should still receive a dedicated review by a frontend developer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes all of the changes from the Pull Request into Fieldmanager (see
alleyinteractive/wordpress-fieldmanager#399)
except for the unit tests, which will take some more work to decouple.