-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python Version #25
base: master
Are you sure you want to change the base?
Python Version #25
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! (As discussed in #18.)
I realized that there are probably some folks using wtf
on ancient systems where there's no default Python 3.6+, or even no default Python 3.0+ (cough RHEL/CentOS 6 cough 💩).
I created a python27
branch (currently matching master
), and we should add a bit of documentation explaining how to install this with Python 2.7 where needed.
what is the default version of Python in CentOS 6? Seems like it is 2.7, but i havent found anything concrete for it |
Yep, that's what it is on all the ancient CentOS 6 servers which I've ever had the misfortune of using 😂. (No wait, I think one of them only had 2.6 but 💩.) Ubuntu 16.04/xenial is the other common-but-ancient distribution which doesn't have Python 3.6+ (it has Python 3.5). I believe that everything in here except |
I was just about to say, that if we remove the f-strings, it can remain 3.5 compatible. And the only thing missing for 2.7 would be for them to install the backport of |
@@ -1,10 +1,11 @@ | |||
#!/usr/bin/env python |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would change python
to python3
here. See #26.
Perhaps change or remove this sentence from the README?
|
Removes compatibility to versions older than 3.6 and uses some of the new features.
I didn't implement them throughout the code since it would require a few sections of the code to be refactored in order to use them to their full extent. So this is more of a preview 😄