Skip to content

fix #21142 seg fault on floating point code #21148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2025
Merged

fix #21142 seg fault on floating point code #21148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions compiler/src/dmd/backend/x86/cgxmm.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -600,6 +600,8 @@ void xmmopass(ref CodeBuilder cdb,elem* e,ref regm_t pretregs)
@trusted
void xmmpost(ref CodeBuilder cdb,elem* e,ref regm_t pretregs)
{
//printf("xmmpost() pretregs: %s\n", regm_str(pretregs));
//elem_print(e);
elem* e1 = e.E1;
elem* e2 = e.E2;
tym_t ty1 = tybasic(e1.Ety);
Expand All @@ -625,9 +627,11 @@ void xmmpost(ref CodeBuilder cdb,elem* e,ref regm_t pretregs)
}

code cs;
regm_t idxregs = 0;
if (!regvar)
{
getlvalue(cdb,cs,e1,0,RM.rw); // get EA
getlvalue(cdb,cs,e1,0,RM.rw); // get EA
idxregs = idxregm(&cs); // index registers used
retregs = XMMREGS & ~pretregs;
if (!retregs)
retregs = XMMREGS;
Expand All @@ -650,7 +654,7 @@ void xmmpost(ref CodeBuilder cdb,elem* e,ref regm_t pretregs)
regm_t rretregs = XMMREGS & ~(pretregs | retregs | resultregs);
if (!rretregs)
rretregs = XMMREGS & ~(retregs | resultregs);
codelem(cgstate,cdb,e2,rretregs,false); // eval right leaf
scodelem(cgstate,cdb,e2,rretregs,idxregs,false); // eval right leaf
const rreg = findreg(rretregs);

const op = xmmoperator(e1.Ety, e.Eoper);
Expand Down
16 changes: 16 additions & 0 deletions compiler/test/runnable/mars1.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2549,6 +2549,21 @@ void test9()

////////////////////////////////////////////////////////////////////////

void test10()
{
double a,b,c;
double* pa,pb;

a = 5;
b = a++;
assert(a == 6);
pa = &a;
pb = &b;
*pb = (*pa)++;
}

////////////////////////////////////////////////////////////////////////

int main()
{
// All the various integer divide tests
Expand Down Expand Up @@ -2651,6 +2666,7 @@ int main()
test20574();
test8();
test9();
test10();

printf("Success\n");
return 0;
Expand Down
Loading