Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extracted Dsymbol.hasPointers to visitor in dsymbolsem #21140

Merged
merged 1 commit into from
Apr 8, 2025

Conversation

MatthewQiu-5
Copy link
Contributor

@MatthewQiu-5 MatthewQiu-5 requested a review from ibuclaw as a code owner April 3, 2025 06:02
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @MatthewQiu-5! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#21140"

ibuclaw
ibuclaw previously requested changes Apr 3, 2025
@MatthewQiu-5 MatthewQiu-5 force-pushed the attrib_sema3 branch 3 times, most recently from 54be009 to 9fca095 Compare April 4, 2025 08:17
/*****************************************
* Is Dsymbol a variable that contains pointers?
*/
bool hasPointers(Dsymbol d)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is used by LDC so it actually needs to remain extern(C++) despite what Iain said. When you add this back to the C++ interface, add it to the dmd namespace, not the global one.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thewilsonator this is correct. top-level symbol is extern(D). The exported C++ symbol is in the dmd namespace in cxxfrontend.d.

@thewilsonator thewilsonator dismissed ibuclaw’s stale review April 4, 2025 14:48

Used by LDC, required to be in the C++ interface

@ibuclaw ibuclaw dismissed thewilsonator’s stale review April 4, 2025 20:20

Symbol in dmd namespace

@thewilsonator
Copy link
Contributor

This has merge conflicts, please rebase.

Copy link
Contributor

@thewilsonator thewilsonator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the style comments from Iain and the merge conflict, this looks good.

@thewilsonator thewilsonator merged commit 69b2b10 into dlang:master Apr 8, 2025
39 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants