Skip to content

Remove auto-cloning of Phobos on start #2286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2018

Conversation

wilzbach
Copy link
Member

@wilzbach wilzbach commented Mar 20, 2018

Auto-cloning is useful, but not if you run make -f posix.mak clean.

This should now be possible due to #2069

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @wilzbach!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@wilzbach wilzbach added WIP and removed WIP labels Mar 20, 2018
@wilzbach
Copy link
Member Author

CC @CyberShadow - I think you are going to like this ;-)

@CyberShadow
Copy link
Member

IIRC this (or a similar change?) was added there because of some difficulties with calculating dependencies. With that in mind do you think this could break anything?

@wilzbach wilzbach force-pushed the remove-auto-clone branch from 34b958a to 95cd00c Compare March 24, 2018 03:30
@wilzbach wilzbach force-pushed the remove-auto-clone branch from 95cd00c to 01f12ba Compare March 24, 2018 03:39
@wilzbach
Copy link
Member Author

IIRC this (or a similar change?) was added there because of some difficulties with calculating dependencies. With that in mind do you think this could break anything?

Yeah you are right. I even added it myself after someone complained about the build process failing due to non-existent repos: #1827

Anyhow - I just tested this with a build from scratch and it looks like everything is working fine and we only need to depend on DMD with the shell trick as include osmodel.mak doesn't work otherwise.
PHOBOS_LATEST_FILES is a relict from the times where we copied Phobos entirely for the writeln pipeline.

Copy link
Member

@CyberShadow CyberShadow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cautiously optimistic that this won't break things in ways that are not currently obvious...

@dlang-bot dlang-bot merged commit c88c08a into dlang:master Mar 24, 2018
@wilzbach wilzbach deleted the remove-auto-clone branch July 18, 2018 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants