Skip to content

Fix protobuf methods gated incorrectly with prost feature #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
djkoloski merged 1 commit into from
Feb 27, 2025
Merged

Fix protobuf methods gated incorrectly with prost feature #103

djkoloski merged 1 commit into from
Feb 27, 2025

Conversation

@GuyLewin
Copy link
Contributor

@GuyLewin GuyLewin commented Feb 27, 2025

When commenting out protobuf from default-encoding-set we noticed I missed updating 2 methods when I worked on the protobuf impl.

@GuyLewin
Copy link
Contributor Author

GuyLewin commented Feb 27, 2025

Another breakage due to dependency (msgpacker this time with nightly feature). Taking a look

@GuyLewin
Copy link
Contributor Author

GuyLewin commented Feb 27, 2025

Yeah MaybeUninit::uninit_array was removed since it was never in stable (rust-lang/rust#96097).
It's used several times in msgpacker: https://github.com/codx-dev/msgpacker/blob/main/msgpacker/src/unpack/common.rs#L100C46-L100C58.

I filed this: codx-dev/msgpacker#17

@djkoloski djkoloski force-pushed the fix/protobuf_wrong_feature_gating branch from 0a6385b to 030f137 Compare February 27, 2025 13:45
@djkoloski djkoloski merged commit c8d7f76 into djkoloski:master Feb 27, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@GuyLewin @djkoloski