UITransform translation lens#162
Merged
Merged
Conversation
djeedai
requested changes
Jan 24, 2026
djeedai
left a comment
djeedai
left a comment
Owner
There was a problem hiding this comment.
Thanks for the PR! I don't mind adding that lens, seems animating UI is a very common use case, so I'm fine paying the maintenance cost for that one. The "limited to px" also, it's too complex to handle all UI values and generally undefined anyway. However there's a few issues:
- branch has conflicts (my bad)
- unless there's an overwhelming concern (with profiling data) about
nlerp()I much rather have something "correct" likeslerp()instead
djeedai
added
enhancement
extrawurst
force-pushed
the
ui-translation-lens
branch
from
4e8b36e to
59ba0ae
Compare
Contributor
Author
|
@djeedai ok conflicts and comments resolved I think. |
djeedai
approved these changes
Jan 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
opening this as a RFC:
as it only allows
pxright now.