Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split artifacts to allow deps to start without the catalog installed #9

Merged
merged 3 commits into from
Dec 3, 2019

Conversation

Lambeaux
Copy link
Collaborator

@Lambeaux Lambeaux commented Dec 2, 2019

Decouples the dependency tooling from the catalog APIs. The klojure-repl is now a jar that is embedded in the klojure-catalog and klojure-deps blueprint bundles. They are separate repls that are independently deployable and accessible on different ports (7889 and 7888 respectively). Also standardizes the package names.

@Lambeaux
Copy link
Collaborator Author

Lambeaux commented Dec 3, 2019

❗️ Trying to get the docs to generate properly, but running mvn clojure:run -Dclojure.script=src/main/clojure/main.clj in the klojure-docs module does make a site but it's as if all the data was ignored. No namespaces. No project metadata from the pom (even though the file path is correct and the xml does find the pom and parses fine). Only the -main function has docs. Added pseudo logging statements and verified all the data is there.

Tried looking at the guide (https://github.com/weavejester/codox#codox) but I don't think I'm missing anything.

Going to try working with absolute paths next to see if that helps.

@Lambeaux Lambeaux requested a review from djblue December 3, 2019 09:45
@Lambeaux
Copy link
Collaborator Author

Lambeaux commented Dec 3, 2019

Temporarily removing the API doc generation. Will restore it after other priorities are satisfied. Created #10 to track that effort.

@Lambeaux Lambeaux merged commit 7cd63de into djblue:master Dec 3, 2019
@Lambeaux Lambeaux deleted the split branch December 3, 2019 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants