Fixing JS admin widget to properly update the field value #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aste/cut/undo events occur in any text-input, in addition to manually typing (keyup events etc.)
|
@andrewhayes1979 thank you. Please also see #161. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, copy/paste/cut/undo events are ignored by the admin widget, it fails to update the internal field-value...saving means any copy-n-pasted text is lost (unless you also manually typed somewhere in the field too).
Only manual typing (via keyup events) works currently
This fix makes all input-changing events update the internal state of the field.
Tested in Chrome & Firefox...this is recommended as the standard cross-browser way to handle all these events.