Skip to content

Extract decorative arrows in CSS #2063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Extract decorative arrows in CSS #2063

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3d2c0ef
Extract the arrow into CSS generated decorative content
tut-tuuut May 2, 2025
9bbcf98
Remove unused templates
tut-tuuut May 8, 2025
baab5e6
Extract decorative arrows into CSS on fundraising form
tut-tuuut May 8, 2025
d2a6e77
Hide decorative <hr> from screen readers
tut-tuuut May 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions djangoproject/scss/_style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1345,6 +1345,18 @@ label[for] {
margin: 10px 0;
}

.cta.arrow {
height: auto;
&::after {
content: " →" / "";
}
&:dir(rtl) {
&::after {
content: " ←" / "";
}
}
}

.callout-right {
@include respond-min(768px) {
float: right;
Expand Down
9 changes: 0 additions & 9 deletions djangoproject/templates/contact/coc.html
View file
Open in desktop

This file was deleted.

23 changes: 0 additions & 23 deletions djangoproject/templates/contact/coc_form.html
View file
Open in desktop

This file was deleted.

6 changes: 4 additions & 2 deletions djangoproject/templates/contact/foundation.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ <h1>{% translate "Contact the Django Software Foundation" %}</h1>
<a href="https://forum.djangoproject.com">Django Forum</a>.
{% endblocktranslate %}
</p>
<form action="." method="post" accept-charset="utf-8" class="form-input">
<form action="." method="post" accept-charset="utf-8">
{% csrf_token %}
<div>
{{ form.name.as_field_group }}
Expand All @@ -44,6 +44,8 @@ <h1>{% translate "Contact the Django Software Foundation" %}</h1>
{{ form.body.as_field_group }}
</div>
{{ form.captcha }}
<p class="submit"><input type="submit" class="cta" value="{% translate "Send &rarr;" %}"></p>
<div class="submit">
<button type="submit" class="cta arrow">{% translate "Send" %}</button>
</div>
</form>
{% endblock %}
22 changes: 11 additions & 11 deletions djangoproject/templates/fundraising/manage-donations.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
{% for message in messages %}
<p>{{ message }}</p>
{% endfor %}
<hr>
<hr aria-hidden="true" />
{% endif %}

{% endblock %}
Expand All @@ -23,20 +23,20 @@ <h1>{% translate "Manage your donations to the Django Software Foundation" %}</h
{% endblocktranslate %}
</p>

<form enctype="multipart/form-data" action="" method="post" class="form-input django-hero-form"
<form enctype="multipart/form-data" action="" method="post" class="django-hero-form"
data-stripe-key="{{ stripe_publishable_key }}" data-stripe-icon="{% static 'img/dj-stripe-icon.jpg' %}"
data-update-card-url="{% url 'fundraising:update-card' %}">
<h2>{% translate "Manage your participation in the fundraising campaigns" %}</h2>
<p>{% translate "Information entered below will be visible on all of your donations to the Django Project." %}</p>
{% csrf_token %}
{% include 'fundraising/includes/_form.html' with form=hero_form %}
<p class="submit">
<input type="submit" class="cta" value="{% translate "Save &rarr;" context "Save personal details about donation" %}">
</p>
<div class="submit">
<button type="submit" class="cta arrow">{% translate "Save" context "Save personal details about donation" %}</button>
</div>
{# Always include to avoid "Management form has been tampered with" if no recurring donations exist #}
{{ modify_donations_formset.management_form }}
{% if recurring_donations %}
<hr />
<hr aria-hidden="true" />
<h2>{% translate "Modify your recurring donations" %}</h2>
<p>{% translate "Update the time interval or amount of your recurring donation here:" %}</p>
{% for form in modify_donations_formset %}
Expand All @@ -47,11 +47,11 @@ <h2>{% translate "Modify your recurring donations" %}</h2>
<span class="change-card-result"></span>
</div>
{% endfor %}
<p class="submit">
<input type="submit" class="cta" value="{% translate "Save &rarr;" context "Save personal details about donation" %}">
</p>
<div class="submit">
<button type="submit" class="cta arrow">{% translate "Save" context "Save personal details about donation" %}</button>
</div>
</form>
<hr />
<hr aria-hidden="true" />
<h2>{% translate "Cancel your recurring donations" %}</h2>
<p>{% translate "You can cancel your recurring donation to the Django Software Foundation anytime." %}</p>
<ul>
Expand All @@ -72,7 +72,7 @@ <h2>{% translate "Cancel your recurring donations" %}</h2>
</form>
{% endif %}
{% if past_payments %}
<hr />
<hr aria-hidden="true" />
<h2>{% translate "Your past donations" %}</h2>
<ul>
{% for payment in past_payments %}
Expand Down
Loading