Refactored messages.js
#1852
Open
Refactored messages.js
#1852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Simplified code using a combination of CSS and JavaScript - Stopped using jQuery - Moved refactored code to `djangoproject.js` This patch should bring no user-facing changes. Refs django#1827
adamzap
commented
Dec 28, 2024
| @@ -3416,6 +3416,8 @@ ul.corporate-members li { | |||
| color: $green-dark; | |||
| border: 1px solid $green-dark; | |||
| border-radius: 4px; | |||
| opacity: 1; | |||
| transition: opacity 400ms; | |||
There was a problem hiding this comment.
The 400ms value here matches the value in the JavaScript. I'd much prefer using a CSS transition than trying to fade the element out in JavaScript.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
djangoproject.jsThis patch should bring no user-facing changes.
Refs #1827
The easiest way I found to test with was to add the following code to the bottom of
blog.views.BlogViewMixinright before the return:Then test this way:
/weblog/) section of the site