Fixed the atomic transaction issue

[arpan8925]

1. Added @transaction.atomic decorator to the checkout_session_completed method

2. All database operations are now wrapped in a transaction:

    - Creating/getting the DjangoHero
    - Creating the Donation
    - Creating the Payment (for one-time donations)
   

[arpan8925]

Solved issue of #1764

[bmispelon]

Hi and thanks for working on this! 🎸

Decorating checkout_sesion_completed() like this shoudl work I think, but I'm not sure it's the best place to add the atomic block. If instead we had with transaction.atomic() before calling handler() inside WebhookHandler.handle(), then all web hooks would be fixed, not just the one.

There also need to be tests added, to make sure the behavior continues to work even as we refactor the code in the future.

Let me know what you think!

[arpan8925]

@bmispelon Check if it fixes the issue, I made a separate file for the webhook test, review please

[bmispelon]

@bmispelon Check if it fixes the issue, I made a separate file for the webhook test, review please

@arpan8925 The test are not working, did you try to run them locally? I see two failures here in the CI, they seem to be the same error:

 ======================================================================
  ERROR: test_checkout_session_completed_atomic (fundraising.tests.test_webhook.TestWebhooks.test_checkout_session_completed_atomic)
  ----------------------------------------------------------------------
  Traceback (most recent call last):
    File "/opt/hostedtoolcache/Python/3.12.7/x64/lib/python3.12/unittest/mock.py", line 1395, in patched
      return func(*newargs, **newkeywargs)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    File "/home/runner/work/djangoproject.com/djangoproject.com/fundraising/tests/test_webhook.py", line 109, in test_checkout_session_completed_atomic
      self.client.post(
    File "/home/runner/work/djangoproject.com/djangoproject.com/.tox/py312-tests/lib/python3.12/site-packages/django/test/client.py", line 1070, in post
      response = super().post(
                 ^^^^^^^^^^^^^
    File "/home/runner/work/djangoproject.com/djangoproject.com/.tox/py312-tests/lib/python3.12/site-packages/django/test/client.py", line 490, in post
      return self.generic(
             ^^^^^^^^^^^^^
    File "/home/runner/work/djangoproject.com/djangoproject.com/.tox/py312-tests/lib/python3.12/site-packages/django/test/client.py", line 617, in generic
      return self.request(**r)
             ^^^^^^^^^^^^^^^^^
    File "/home/runner/work/djangoproject.com/djangoproject.com/.tox/py312-tests/lib/python3.12/site-packages/django/test/client.py", line 1013, in request
      self.check_exception(response)
    File "/home/runner/work/djangoproject.com/djangoproject.com/.tox/py312-tests/lib/python3.12/site-packages/django/test/client.py", line 743, in check_exception
      raise exc_value
    File "/home/runner/work/djangoproject.com/djangoproject.com/.tox/py312-tests/lib/python3.12/site-packages/django/core/handlers/exception.py", line 55, in inner
      response = get_response(request)
                 ^^^^^^^^^^^^^^^^^^^^^
    File "/home/runner/work/djangoproject.com/djangoproject.com/.tox/py312-tests/lib/python3.12/site-packages/django/core/handlers/base.py", line 197, in _get_response
      response = wrapped_callback(request, *callback_args, **callback_kwargs)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    File "/home/runner/work/djangoproject.com/djangoproject.com/.tox/py312-tests/lib/python3.12/site-packages/django/views/decorators/http.py", line 64, in inner
      return func(request, *args, **kwargs)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    File "/home/runner/work/djangoproject.com/djangoproject.com/.tox/py312-tests/lib/python3.12/site-packages/django/views/decorators/csrf.py", line 65, in _view_wrapper
      return view_func(request, *args, **kwargs)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    File "/home/runner/work/djangoproject.com/djangoproject.com/fundraising/views.py", line 204, in receive_webhook
      return WebhookHandler(event).handle()
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    File "/home/runner/work/djangoproject.com/djangoproject.com/fundraising/views.py", line 222, in handle
      return handler()
             ^^^^^^^^^
    File "/home/runner/work/djangoproject.com/djangoproject.com/fundraising/views.py", line 304, in checkout_session_completed
      session.customer, stripe_version="2020-08-27"
      ^^^^^^^^^^^^^^^^
  AttributeError: 'dict' object has no attribute 'customer'

[arpan8925]

It Seems , test working now !

The test is failing because the webhook handler isn't properly handling the InvalidRequestError from Stripe.

However, Everything fixed.. Please Check & Review

[arpan8925]

[arpan8925]

@bmispelon Can you review ?

[marksweb]

@arpan8925 I'm sure you'll get another review on here when someones free to do so. We're all volunteers here doing this in our free time.

[bmispelon]

Hi,

There are several issues with your PR:

• This version is very different and much more complicated than the one you submitted initially, and it contains unexplained code changes
• Instead of adding a new test method to the TestWebhooks you created a whole new file with some of the old tests copy/pasted.
• There are now conflicts with other changes that have been merged since this pull request was opened (this is related to the first point)

Could you revert the changes and go back to the version you had at the beginning with only a with atomic() block? Then I will make some proposals for how to add tests for that.

Thanks! 🎸