-
-
Notifications
You must be signed in to change notification settings - Fork 967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
funding.json (see https://floss.fund) #1753
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, thanks! 🎸
Some basic tests might be nice to have. I'm thinking a spot-check that the view is returning a well formed json, maybe also testing a few strategic keys of the response.
Co-authored-by: Baptiste Mispelon <[email protected]>
@bmispelon aw man you're gonna make me write tests!? (yeah you're right, will do) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides adding some tests as Baptiste says, this is great to see! 👏🏼
This adds a
funding.json
, which is a new format developed by https://floss.fund, required if we want to apply for funding from them. I'd like to, so here it is.I don't love that this seems to require adding this
funding-manifest-urls
file to the github repo, that's a bit annoying, but otherwise it fails validation.The alternate approach is to just add this as a static
funding.json
over in django/django and avoid any changes to the website. Doing it that way is certainly less code, but an advantage to doing it as a view is that we can dynamically render the funding tiers etc.