migrate setup.py to pyproject.toml#417
Open
deronnax wants to merge 3 commits intodjango-commons:masterfrom
Open
migrate setup.py to pyproject.toml#417deronnax wants to merge 3 commits intodjango-commons:masterfrom
deronnax wants to merge 3 commits intodjango-commons:masterfrom
Conversation
deronnax
changed the title
deronnax
force-pushed
the
migrate-to-setup-cfg
branch
from
76311d4 to
fbc8ae2
Compare
aminalaee
reviewed
Jun 6, 2024
| "Programming Language :: Python :: 3.8", | ||
| "Programming Language :: Python :: 3.9", | ||
| "Programming Language :: Python :: 3.10", | ||
| "Programming Language :: Python :: 3.11", |
There was a problem hiding this comment.
Suggested change
| "Programming Language :: Python :: 3.11", | |
| "Programming Language :: Python :: 3.11", | |
| "Programming Language :: Python :: 3.12", |
| "Framework :: Django :: 3.2", | ||
| "Framework :: Django :: 4.0", | ||
| "Framework :: Django :: 4.1", | ||
| "Framework :: Django :: 4.2", |
There was a problem hiding this comment.
Suggested change
| "Framework :: Django :: 4.2", | |
| "Framework :: Django :: 4.2", | |
| "Framework :: Django :: 5.0", |
Contributor
|
Rebase? Add new versions of Django and Python? |
Member
Author
|
I'll do it when I have a hint from owners that they are still around. |
Contributor
|
@asherf Can we please move forward with this modernization? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
declarative config is encouraged by setuptools as it avoid running arbitrary code and reduces boilerplate.
EDIT: I did not notice the project already had a pyproject.toml with a
build-systemsection, let's move everything to pyproject.toml 🎉 .