Skip to content

Conversation

@vinitkumar
Copy link
Member

@vinitkumar vinitkumar commented Oct 24, 2025

This PR adds a new requirements file for testing against Django 6.0 with CMS 5.0, and updates the GitHub Actions workflow to include it in the test matrix.

Changes:

  • Add tests/requirements/dj60_cms50.txt
  • Update .github/workflows/test.yml to include dj60_cms50.txt in the matrix

This ensures compatibility with upcoming Django 6.0 release.

Summary by Sourcery

Add Django 6.0 support to the CI pipeline by defining a new test requirements file and expanding the workflow matrix to include Django 6.0.

CI:

  • Include Django 6.0 and CMS 5.0 in the GitHub Actions test matrix

Tests:

  • Add requirements file for testing with Django 6.0 and CMS 5.0

- Add dj60_cms50.txt requirements file for Django 6.0 and CMS 5.0
- Update GitHub Actions workflow to include the new requirements file in test matrix

Amp-Thread-ID: https://ampcode.com/threads/T-2bc149c2-fa90-4edd-9d33-5bcc61e7e0fe
Co-authored-by: Amp <[email protected]>
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Oct 24, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR integrates Django 6.0 into the CI by adding a new requirements file for CMS 5.0 testing and extending the GitHub Actions test matrix.

File-Level Changes

Change Details Files
Add Django 6.0 + CMS 5.0 test requirements file
  • Create tests/requirements/dj60_cms50.txt
tests/requirements/dj60_cms50.txt
Extend CI workflow matrix to include Django 6.0
  • Append dj60_cms50.txt to the test matrix in test.yml
.github/workflows/test.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented Oct 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.78%. Comparing base (68036fc) to head (d2552fe).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #72   +/-   ##
=======================================
  Coverage   91.78%   91.78%           
=======================================
  Files          18       18           
  Lines         828      828           
  Branches       89       89           
=======================================
  Hits          760      760           
  Misses         42       42           
  Partials       26       26           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

vinitkumar and others added 3 commits October 25, 2025 03:18
- Install uv in CI
- Use uv venv and uv pip install instead of pip
- Update Python matrix to include 3.13 and 3.14
- Update classifiers for Python 3.13, 3.14 and Django 6.0, CMS 6.0
- Change requires-python to >=3.10

Amp-Thread-ID: https://ampcode.com/threads/T-2bc149c2-fa90-4edd-9d33-5bcc61e7e0fe
Co-authored-by: Amp <[email protected]>
- Ran pyupgrade --py310-plus on all Python files
- Updated syntax for better compatibility with Python 3.10+

Amp-Thread-ID: https://ampcode.com/threads/T-2bc149c2-fa90-4edd-9d33-5bcc61e7e0fe
Co-authored-by: Amp <[email protected]>
- Removed unused imports: typing.Optional and typing.Union
- All ruff checks now pass

Amp-Thread-ID: https://ampcode.com/threads/T-2bc149c2-fa90-4edd-9d33-5bcc61e7e0fe
Co-authored-by: Amp <[email protected]>
@vinitkumar vinitkumar requested a review from fsbraun October 24, 2025 21:52
@fsbraun
Copy link
Member

fsbraun commented Oct 24, 2025

@vinitkumar Should uv.lock be part of the repo?

@vinitkumar
Copy link
Member Author

@vinitkumar Should uv.lock be part of the repo?

Sorry for late reply, uv.lock is removed. We are not ready to switch to it yet, so no need to commit it with the code. I committed that by mistake. Sorry!

pyproject.toml Outdated
"Framework :: Django CMS :: 4.0",
"Framework :: Django CMS :: 4.1",
"Framework :: Django CMS :: 5.0",
"Framework :: Django CMS :: 6.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"Framework :: Django CMS :: 6.0",

Not there yet... ;-)

@vinitkumar
Copy link
Member Author

@fsbraun Should be ready now once all the tests pass.

Copy link
Member

@fsbraun fsbraun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fsbraun fsbraun merged commit 280789c into main Oct 25, 2025
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants