-
Notifications
You must be signed in to change notification settings - Fork 3
Add Django 6.0 support to CI #72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Add dj60_cms50.txt requirements file for Django 6.0 and CMS 5.0 - Update GitHub Actions workflow to include the new requirements file in test matrix Amp-Thread-ID: https://ampcode.com/threads/T-2bc149c2-fa90-4edd-9d33-5bcc61e7e0fe Co-authored-by: Amp <[email protected]>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR integrates Django 6.0 into the CI by adding a new requirements file for CMS 5.0 testing and extending the GitHub Actions test matrix. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #72 +/- ##
=======================================
Coverage 91.78% 91.78%
=======================================
Files 18 18
Lines 828 828
Branches 89 89
=======================================
Hits 760 760
Misses 42 42
Partials 26 26 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Install uv in CI - Use uv venv and uv pip install instead of pip - Update Python matrix to include 3.13 and 3.14 - Update classifiers for Python 3.13, 3.14 and Django 6.0, CMS 6.0 - Change requires-python to >=3.10 Amp-Thread-ID: https://ampcode.com/threads/T-2bc149c2-fa90-4edd-9d33-5bcc61e7e0fe Co-authored-by: Amp <[email protected]>
- Ran pyupgrade --py310-plus on all Python files - Updated syntax for better compatibility with Python 3.10+ Amp-Thread-ID: https://ampcode.com/threads/T-2bc149c2-fa90-4edd-9d33-5bcc61e7e0fe Co-authored-by: Amp <[email protected]>
- Removed unused imports: typing.Optional and typing.Union - All ruff checks now pass Amp-Thread-ID: https://ampcode.com/threads/T-2bc149c2-fa90-4edd-9d33-5bcc61e7e0fe Co-authored-by: Amp <[email protected]>
|
@vinitkumar Should |
…n 3.11 compatibility Amp-Thread-ID: https://ampcode.com/threads/T-35fcfaef-4b84-4332-8c74-0609382f872c Co-authored-by: Amp <[email protected]>
Sorry for late reply, uv.lock is removed. We are not ready to switch to it yet, so no need to commit it with the code. I committed that by mistake. Sorry! |
pyproject.toml
Outdated
| "Framework :: Django CMS :: 4.0", | ||
| "Framework :: Django CMS :: 4.1", | ||
| "Framework :: Django CMS :: 5.0", | ||
| "Framework :: Django CMS :: 6.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "Framework :: Django CMS :: 6.0", |
Not there yet... ;-)
|
@fsbraun Should be ready now once all the tests pass. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR adds a new requirements file for testing against Django 6.0 with CMS 5.0, and updates the GitHub Actions workflow to include it in the test matrix.
Changes:
This ensures compatibility with upcoming Django 6.0 release.
Summary by Sourcery
Add Django 6.0 support to the CI pipeline by defining a new test requirements file and expanding the workflow matrix to include Django 6.0.
CI:
Tests: