Skip to content

Conversation

@msk-nightingale
Copy link

No description provided.

Copy link
Owner

@dixudx dixudx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice feature. Thanks for your contribution.

target_folder_base = os.path.join(current_folder, site)
if not os.path.isdir(target_folder_base):
os.mkdir(target_folder_base)
target_folder_other = os.path.join(current_folder, site+'-other')
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not using the origin site name as the new folder name? And we could avoid downloading the duplicate photos/videos as well.

I mean if the media in A is reblogged from B, you can just create a new folder B to store this media, instead of current A-other.

Copy link
Author

@msk-nightingale msk-nightingale Jul 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not comfortable when threre ara many reposts from many different blogs and a user need to see lot of photos / videos...

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not comfortable when threre ara many reposts from many different blogs and a user need to see lot of photos / videos...

Still use A and B as an example.

A: media1
   media2 (rebloged from B)
B: media2 (rebloged from C)
   media3

What if a user is trying to downloading media2 from site A, you will save it to A-other folder. And later if downloading from site B, media2 will be downloaded again and save to B-other folder.

Actually they are identical, which should not be save multiple times.

Then why not directly saving it to folder C (for site C)?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe... I made this feature for me and it's bad for me what you say.

for post in posts:
if '@reblogged-from-url' in post:
target_folder=target_folder_other
if len (sys.argv) > 2 and sys.argv[2] == '-norepost':
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better add some help message on this new flag in the main function.

Update README as well please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants