Update rellax.js #242
Closed
Update rellax.js #242
+84
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding new property switch called 'leadByViewPort' to manage if the animation should only happen when the element is within the ViewPort area.
|
@moeamaya, will you please take a look a the PR proposed? Thanks. |
- Removing use of JQuery from the library as previous suggestion was using the $. dependency. - Also removing hardwire value referencing the id of an element.
Removing more $ dependencies
|
@cvillalobos Do you mind making a new PR without the formatting changes? |
|
@moeamaya, Ok yes, I'll try to send it today. Thanks for taking the time to review this. I'll make sure to notify you when the new PR is in place. |
Removing formatting changes.
|
Closing PR as it has included some inconvenient formatting changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that the custom wrapper is not precisely working and some other have reported related issues I am adding here a new property switch called 'leadByViewPort' to manage if the animation should only happen when the element is within the ViewPort area.
The editor has automatically formatted/indexed a few lines throughout the file. However, main changes directly related to the new attribute added are the following:
leadByViewPort: false,if ((!self.options.leadByViewPort) || (self.options.leadByViewPort && $('#parallax-wrapper').isInViewport())) {