FIX/rellax.js: introduce document.onreadystatechange to call init() #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fter document load
Open
|
@guidoschmidt Can this be solved by calling the rellax.js when the document is ready? If so I will just update the README instead of requiring it in the code. |
|
True, might actually be the better option to put it into the README and ensure a finished document load on the user side of rellax.js 🤔 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to solve Issue #40. I'm absolutely not sure if that really solves the bug, as I have used rellax.js only for some hours yet and lacking of experience using it as a library. But it seemed to me, that the
init()function needs to be called after the document has loaded in order to get more correctish values for the y position 🤔See https://streamable.com/2fwnq for demo