Master

[divyagovindaiah]

No description provided.

[ManojCKrishna]

Follow proper naming conventions and remove the files which are not required for ex: terraform.tfstate files
Provide commit message based on the context.

[ManojCKrishna]

What if i change the name of my subnet
Is the syntax correct?
Please refer to the documentation i shared earlier

[ManojCKrishna]

Is this necessary?

[ManojCKrishna]

Why do you need 3 security groups?

[divyagovindaiah]

yea i will modify , What if i change the name of my subnet Is the syntax correct? i did not get this one can please tell once again

…

On Fri, Dec 2, 2022 at 5:51 PM Manoj Krishna ***@***.***> wrote: ***@***.**** requested changes on this pull request. Follow proper naming conventions and remove the files which are not required for ex: terraform.tfstate files ------------------------------ In eks.tf <#1 (comment)> : > @@ -0,0 +1,45 @@ +module "eks" { + source = "terraform-aws-modules/eks/aws" + version = "17.24.0" + + cluster_name = "my-eks" + cluster_version = "1.21" + + + vpc_id = resource.aws_cloudformation_stack.network.outputs["MyVpc"] + subnet_ids = [resource.aws_cloudformation_stack.network.outputs["Subnet1"], + resource.aws_cloudformation_stack.network.outputs["Subnet2"]] What if i change the name of my subnet Is the syntax correct? Please refer to the documentation i shared earlier ------------------------------ In eks.tf <#1 (comment)> : > +module "eks" { + source = "terraform-aws-modules/eks/aws" + version = "17.24.0" + + cluster_name = "my-eks" + cluster_version = "1.21" + + + vpc_id = resource.aws_cloudformation_stack.network.outputs["MyVpc"] + subnet_ids = [resource.aws_cloudformation_stack.network.outputs["Subnet1"], + resource.aws_cloudformation_stack.network.outputs["Subnet2"]] + + + + + enable_irsa = true Is this necessary? ------------------------------ In msk.tf <#1 (comment)> : > @@ -0,0 +1,26 @@ +resource "aws_msk_cluster" "example" { + cluster_name = "example" + kafka_version = "3.3.1" + number_of_broker_nodes = 3 + + + + broker_node_group_info { + instance_type = "kafka.t3.small" + client_subnets = [resource.aws_cloudformation_stack.network.outputs["Subnet1"], + resource.aws_cloudformation_stack.network.outputs["Subnet2"], + resource.aws_cloudformation_stack.network.outputs["Subnet3"]] + security_groups = [resource.aws_cloudformation_stack.network.outputs["Securitygroup1"], + resource.aws_cloudformation_stack.network.outputs["Securitygroup2"], + resource.aws_cloudformation_stack.network.outputs["Securitygroup1"]] Why do you need 3 security groups? — Reply to this email directly, view it on GitHub <#1 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A2KGK6YEHCNR5DTV5DOKNY3WLHSV5ANCNFSM6AAAAAASR223LA> . You are receiving this because you authored the thread.Message ID: ***@***.***>