[DIT-6187] Test coverage improvements #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azjgard
commented
Mar 7, 2024
| TEXT_DIR, | ||
| TEXT_FILE, | ||
| }; | ||
| export default new (class { |
There was a problem hiding this comment.
In all places but one we already imported the default export of this file (and I refactored that one place), so this doesn't change anything functionally, but we can utilize the ES6 getter to dynamically set these values in tests by changing environment variables at runtime.
azjgard
commented
Mar 7, 2024
azjgard
commented
Mar 7, 2024
| @@ -0,0 +1,367 @@ | |||
| import fs from "fs"; | |||
There was a problem hiding this comment.
This file was renamed from pull.test.ts to pull-lib.test.ts -- most of code shown as changed I didn't actually touch. I will leave a comment on the things that were changed.
azjgard
commented
Mar 7, 2024
| }); | ||
| }); | ||
|
|
||
| const { getJsonFormat } = _test; |
There was a problem hiding this comment.
Added tests from here down
azjgard
commented
Mar 7, 2024
lib/pull.test.ts
Outdated
There was a problem hiding this comment.
This should be reviewed as a brand new file. All of the old code in the file was moved to pull-lib.test.ts.
jaerod95
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Improves mocking capabilities generally and adds a bunch of tests to improve coverage.
Context
https://linear.app/dittowords/issue/DIT-6187/cli-audit-existing-tests
https://linear.app/dittowords/issue/DIT-6186/cli-pull-integration-tests-which-validate-files-written-to-disk
Test Plan
pullwrites files to disk with a non-default configuration