Update weaver to 0.10.0#1823
Conversation
| val missingHeadersMessage = | ||
| s"Expected to find all of $expectedHeaders inside of $headers" |
There was a problem hiding this comment.
This extraction helps avoid false positive error that started happening after updating weaver:
[info] [tests] compiling 5 Scala sources to /home/majk/Code/personal/smithy4s/modules/tests/target/jvm-2.13/classes ...
[error] [tests] /home/majk/code/smithy4s/modules/tests/src/smithy4s/tests/PizzaSpec.scala:432:15: possible missing interpolator: detected interpolated identifiers `$expectedHeaders`, `$headers`
[error] [tests] } yield {
[error] [tests] ^
[info] [bootstrapped] compiling 1 Scala source to /home/majk/code/smithy4s/modules/bootstrapped/target/jvm-2.13/classes ...
[error] [tests] No warnings can be incurred under -Werror.
[error] [tests] two errors found
[error] [tests] (tests / Compile / compileIncremental) Compilation failed
There was a problem hiding this comment.
I thought we had it fixed in typelevel/weaver-test#179 :( (I guess we all did)
| filter match { | ||
|
|
||
| case atLine(`suiteName`, line) => { case TestName(_, indicator, _) => | ||
| indicator.line == line |
There was a problem hiding this comment.
line in SourceLocation is no longer available in weaver, the field was not intended for end user API. The atLine was not used anyway so I dropped it altogether
majk-p
force-pushed
the
update/weaver-0.10.0
branch
from
f40daff to
df40c6c
Compare
|
I don't understand why f40daff didn't work and df40c6c does - the former had all the commits except #1822, and There must've been some ungodly event that resulted in the file randomly not being packaged into the jar. There were no prior CI executions for this PR or branch, so it wasn't cache pollution either. I have no clue. |
3 participants
This is prerequisite to #1821, so that the changeset for moving to new Scala Native is minimal