chore: remove usage of the prefer-global rules #11279
Open
+27
−133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
didinele
requested review from
Jiralite,
SpaceEEC,
almeidx,
almostSouji,
ckohen,
kyranet,
monbrey and
sdanialraza
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
github-actions
bot
added
packages:discord.js
packages:rest
packages:voice
packages:ws
labels
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11279 +/- ##
==========================================
- Coverage 44.76% 44.72% -0.05%
==========================================
Files 316 316
Lines 18164 18146 -18
Branches 1811 1813 +2
==========================================
- Hits 8132 8115 -17
+ Misses 10020 10019 -1
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Qjuh
reviewed
Nov 17, 2025
Member
Qjuh
left a comment
Qjuh
left a comment
There was a problem hiding this comment.
including api-extractor in this change is correct
| @@ -1,7 +1,3 @@ | |||
| #!/usr/bin/env node | |||
Member
Author
There was a problem hiding this comment.
I'm not sure, an eslint rule fired on it. Gonna look into it
| @@ -1,6 +1,5 @@ | |||
| import { stat, mkdir, writeFile } from 'node:fs/promises'; | |||
| import { join } from 'node:path'; | |||
| import { cwd } from 'node:process'; | |||
| @@ -1,6 +1,5 @@ | |||
| import { mkdir, stat, writeFile } from 'node:fs/promises'; | |||
| import { join } from 'node:path'; | |||
| import { cwd } from 'node:process'; | |||
| @@ -1,5 +1,4 @@ | |||
| import { readFile } from 'node:fs/promises'; | |||
| import process, { cwd } from 'node:process'; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should I have ignored api-extractor?
Closes #11272