Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: don't check in generated files #208

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Conversation

salarkhan
Copy link
Contributor

These files are generated by the build step, no need to be checking in files that aren't explicitly listed in https://github.com/discord/lilliput/blob/master/deps/osx/build-info.json or it's linux counterpart

@salarkhan salarkhan requested a review from skidder December 20, 2024 23:43
@salarkhan salarkhan changed the title remove files that we dont need to check in cleanup: don't check in generated files Dec 20, 2024
Copy link
Contributor

@skidder skidder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@salarkhan salarkhan merged commit f69d0d3 into master Dec 20, 2024
6 checks passed
@salarkhan salarkhan deleted the salar/dont-checkin-deps branch December 20, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants