Created a Discord Subscription representation as well as a method for… #2885
Conversation
freya022
left a comment
freya022
left a comment
There was a problem hiding this comment.
Please also add the following endpoints:
SubscriptionPaginationAction JDA#retrieveSubscriptions()Subscription JDA#retrieveSubscription(String)(andSubscription JDA#retrieveSubscription(String))
And events:
| * Representation of a Discord Subscription | ||
| * <br> This class is immutable | ||
| */ | ||
| public class Subscription |
| this.status = status; | ||
| } | ||
|
|
||
| public Long getId() |
There was a problem hiding this comment.
| public Long getId() | |
| public long getId() |
| return id; | ||
| } | ||
|
|
||
| public Long getSubscriberId() |
There was a problem hiding this comment.
| public Long getSubscriberId() | |
| public long getSubscriberId() |
| } | ||
|
|
||
|
|
||
| public JDAImpl getApi() |
There was a problem hiding this comment.
Not needed imo, and also don't expose internals in API
| { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
| { | |
| return false; | |
| } | |
| return false; |
| /** | ||
| * Representation of a Discord Subscription Status | ||
| */ | ||
| public enum SubscriptionStatus |
There was a problem hiding this comment.
Run the formatter on this class
| return new Subscription( | ||
| getJDA(), | ||
| object.getUnsignedLong("id"), | ||
| object.getUnsignedLong("user_id", 0), |
There was a problem hiding this comment.
| object.getUnsignedLong("user_id", 0), | |
| object.getUnsignedLong("user_id"), |
| ); | ||
| } | ||
|
|
||
| public List<Long> mapDataArrayToLongList(DataArray dataArray) |
There was a problem hiding this comment.
| public List<Long> mapDataArrayToLongList(DataArray dataArray) | |
| private List<Long> mapDataArrayToLongList(DataArray dataArray) |
Maybe rename to mapToLongList
Add endpoints with subscriptions
| */ | ||
| @Nonnull | ||
| @CheckReturnValue | ||
| RestAction<Subscription> retrieveSubscriptionsBySkuId(long skuId); |
There was a problem hiding this comment.
This should accept a SkuSnowflake instead
| */ | ||
| @Nonnull | ||
| @CheckReturnValue | ||
| RestAction<Subscription> retrieveSubscriptionBySkuIdAndSubscriptionId(long skuId, long subscriptionId); |
There was a problem hiding this comment.
Rename to retrieveSubscriptionBySkuId, accept a SkuSnowflake, also make an overload where the subscriptionId is a String.
The overload accepting a String should be implemented, while the long one should be default
@Nonnull
default RestAction<Subscription> retrieveSubscriptionBySkuId(@Nonnull SkuSnowflake sku, long subscriptionId)
{
return retrieveSubscriptionBySkuId(sku, Long.toUnsignedString(subscriptionId));
}| @Override | ||
| public RestAction<Subscription> retrieveSubscriptionsBySkuId(long skuId) | ||
| { | ||
| return new RestActionImpl<>(this, Route.Sku.GET_SUBSCRIPTIONS.compile(Long.toUnsignedString(skuId))); |
There was a problem hiding this comment.
You have to handle the deserialization
| @Override | ||
| public RestAction<Subscription> retrieveSubscriptionBySkuIdAndSubscriptionId(long skuId, long subscriptionId) | ||
| { | ||
| return new RestActionImpl<>(this, Route.Sku.GET_SUBSCRIPTION.compile(Long.toUnsignedString(skuId), Long.toUnsignedString(subscriptionId))); |
| * The subscription {@link Subscription} | ||
| * | ||
| * @return The subscription {@link Subscription} |
There was a problem hiding this comment.
| * The subscription {@link Subscription} | |
| * | |
| * @return The subscription {@link Subscription} | |
| * The {@link Subscription} | |
| * | |
| * @return The {@link Subscription} |
| @@ -0,0 +1,114 @@ | |||
| package net.dv8tion.jda.api.entities.subscription; | |||
| } | ||
|
|
||
| /** | ||
| * The sku id's related to this |
There was a problem hiding this comment.
SKU is an acronym, so use all caps for it
| return subscriberId; | ||
| } | ||
|
|
||
| public @NotNull List<Long> getSkuIdsLong() |
There was a problem hiding this comment.
- Use
@Nonnullinstead - Annotations are on the line before the method declaration
| * @param skuId | ||
| * The sku id of the List |
There was a problem hiding this comment.
Align with @return, check other javadocs with the same issue
| * | ||
| * @param skuId | ||
| * The sku id of the List | ||
| * @return {@link RestAction} - Type: {@link Subscription} |
There was a problem hiding this comment.
There is an extra newline between @param and @return
|
Just as a little User's view from one that works with the App monetizations. This PR would be a blessing to be implemented with a little priority on it, to be able to see what's happening with subscriptions. Without those you only really get to see when subscriptions end. |
4 participants
Pull Request Etiquette
Changes
Closes Issue: NaN
Description
This PR:
-Adds a representation of a Discord Subscription
-Adds a method in EntityBuilder for create a representation