[auth] Provide a fallback mechanic for old-style logins #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The identity storage model has changed and all logins should be using an identity marker. Old users that have been added before this, will not have the marker and while the idea is to migrate the IDs in the DB we still need a fallback to where these may have been created during the upgrade, or where the upgrade for some reason fail to take all the correct identities into account.
judgeaxl
force-pushed
the
feature/legacy-auth-fallback
branch
from
2ee6c3d to
204d830
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to store device_id logins like "username" with a blank identity type, but we now store them as "uuid:username" and the "uuid" identity type. While the goal is to migrate these automatically, we do need a way to fall back and pick up the old names where the upgrade has not yet run, or failed for whatever reason.