Added is_finite check for 4x4 matrix inversion #1469
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1432
The issue is related to multiplications where the result exceeds the maximum value for the underlying numeric representation. See the added tests for example matrices that pass the determinant check but yield infinite values in the inversion code.
Changes:
try_inverse
correctly returnsNone
for singular or near-singular matrices.reproducible_matrix
).Notes:
is_finite
check resulted in a 30% performance penalty (3ns instead of 2ns on my machine).Inf
orNaN
values.probablyalso affects 2x2 and 3x3 matrices.try_inverse
to the method's documentation:Some
is returned. Other definitions would require more involved threshold calculations to define a bound on result precision.