Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename offline app to phone/mobile app #3364

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Rename offline app to phone/mobile app #3364

wants to merge 1 commit into from

Conversation

JoeyStk
Copy link
Contributor

@JoeyStk JoeyStk commented Jan 24, 2025

Short description

As part of the feature to add page based statistics it was decided to use the term phone/mobile app instead of offline app.

Proposed changes

  • Change offline app to phone app
  • Adjust webapp from different variations to Web-App, as recommended by Duden

Side effects

  • Is mobile app better than phone app for the English version? I'm torn...

Resolved issues

Fixes: -

Pull Request Review Guidelines

@JoeyStk JoeyStk added the effort: low Should be doable in <4h label Jan 24, 2025
MizukiTemma
MizukiTemma approved these changes Jan 24, 2025
View reviewed changes
Copy link
Member

@MizukiTemma MizukiTemma left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Is mobile app better than phone app for the English version

I think any naming is fine (and any won't harm).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MizukiTemma MizukiTemma MizukiTemma approved these changes

@PeterNerlich PeterNerlich Awaiting requested review from PeterNerlich

@charludo charludo Awaiting requested review from charludo

@jonbulz jonbulz Awaiting requested review from jonbulz

@jarlhengstmengel jarlhengstmengel Awaiting requested review from jarlhengstmengel

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
effort: low Should be doable in <4h
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoeyStk @MizukiTemma