-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vitest for frontend testing #2810
Conversation
Code Climate has analyzed commit c7a6d03 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 82.2% (0.0% change). View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you a lot 🚀 I think this is a good step forward.
- Small note: Once this PR is merged you can check the checkbox in our meta issue for tests.
- I personally like vitest more than jest for our usecase. I think Jest has a lot of features that we don't need as we are web only and therefore I rather prefer the speed of vitest.
- Lastly the reason why I don't approve yet. Do we need a dev tool for this? I'm kind of lost in the whole discussion about pre-commits and dev commands 😕 Once this question is answered I will approve this PR as it looks good to me so far :)
Special thanks for the dummy test. These things always help me to get started with a new feature :) In the mid-future we can remove it again, but for the beginning it's much appreciated (at least on my side) :)
@JoeyStk I've added a devtool and a pre-commit hook that calls it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not an expert on this matter, but would like to move this forward.
To me this PR works. I didn't face issues when installing this and running the dev-tool. Thank you very much :)
Thank you very much 👍 This really is an improvement! Could you squash the first two commits into one? Then, this is good to go :) |
includes a simple test for url and base64 encoding Configure vitest to not watch files in .venv Watching files in .venv is not required, since we don't have any tests there and it can also lead to problems on platforms that only allow a limited number of file watchers. Co-authored-by: deen13 <[email protected]> Configure import/resover in order to use import within vitest.config.ts eslint/eslint#14667 (reply in thread) Add vitest devtool
Short Description
This pull request configures vitest and adds a simple test as suggested in my review of deps/upgrade_webauthn_2_0.
Proposed Changes
package.json
Pull Request Review Guidelines