form submission: error handling and logging for email notifications #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosado
force-pushed
the
rosado/3338-send-email-fail-handling
branch
from
990d6a3 to
afdd200
Compare
| async post (req, res, next) { | ||
| const result = await this.sendEmails(req, res, next) | ||
| for (const err of (result.errors ?? [])) { | ||
| console.error(err) |
There was a problem hiding this comment.
can be addressed in a later ticket, but as we have now merged the repos we have access to a logger. I'll add a tech debt ticket to update all console messages in the submit part of this repo to use the logger instead
GeorgeGoodall
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently email notification failures are not handled properly. We want the errors handled and logged.
Trello