Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give a more helpful message when endpoint not found in source. #311

Merged
merged 3 commits into from
Jan 6, 2025

Conversation

cjohns-scottlogic
Copy link
Contributor

@cjohns-scottlogic cjohns-scottlogic commented Jan 6, 2025

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Improve the error message when an endpoint isn't found in the the source.

Related Tickets & Documents

QA Instructions, Screenshots, Recordings

Please replace this line with instructions on how to test your changes, a note
on the devices and browsers this has been tested on, as well as any relevant
images for UI changes.

Added/updated tests?

We encourage you to keep the code coverage percentage at 80% and above. Please refer to the Digital Land Testing Guidance for more information.

  • Yes
  • No, and this is why: please replace this line with details on why tests
    have not been included
  • I need help with writing tests

[optional] Are there any post deployment tasks we need to perform?

[optional] Are there any dependencies on other PRs or Work?

CarlosCoelhoSL
CarlosCoelhoSL previously approved these changes Jan 6, 2025
Copy link
Contributor

@CarlosCoelhoSL CarlosCoelhoSL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm just need to fix the CI .yml if you want to merge

@cjohns-scottlogic cjohns-scottlogic merged commit af5714d into main Jan 6, 2025
3 checks passed
@cjohns-scottlogic cjohns-scottlogic deleted the feat/messages-on-failure branch January 6, 2025 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants