Repository navigation
feat: add postgres section for retire-dataset dag - #109
Merged
Merged
Conversation
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Adds a
postgrestask to theretire-datasetDAG. It runs afterdiscover, alongsidefiles, and runs the Postgres loader image with the command./retire.sh(digital-land/digital-land-postgres#31), passingDATASET_NAMEand the sameDRY_RUNvalue asfiles. The loader removes the dataset's rows fromentity,old_entityandentity_subdivided, or only counts them on a dry run. The DAG docs now describe the task and how removed rows can be loaded again.Why
Part 2 of digital-land/digital-land-builder#64. Removing a dataset's files leaves its entities in Postgres, so its entity pages and API results stay live. This is what takes a retired dataset off the site.
Related Tickets & Documents
QA Instructions, Screenshots, Recordings
retire-datasetwithretire-dataset-test(not in the specification) as a dry run (runmanual__2026-10-07T13:43:58):guardpassed anddiscoverloggedno user-facing files found for retire-dataset-test in development-collection-data.postgresstarteddevelopment-sqlite-ingestion-taskwithcommand: ['./retire.sh'],DATASET_NAME: 'retire-dataset-test'andDRY_RUN: 'true', all rendered as plain strings.Retiring retire-dataset-test rows from postgres (DRY_RUN=true)and thenwould remove 0 retire-dataset-test rows fromeach ofentity,old_entityandentity_subdivided. It exited 0, which shows the task reaches the database with the task definition's credentials and removes nothing on a dry run.DRY_RUN=falseremoved only the given dataset's rows. It is deployed to every environment, including production.Added/updated tests?
We encourage you to keep the code coverage percentage at 80% and above. Please refer to the Digital Land Testing Guidance for more information.
have not been included
[optional] Are there any post deployment tasks we need to perform?
[optional] Are there any dependencies on other PRs or Work?